Artion-Contracts icon indicating copy to clipboard operation
Artion-Contracts copied to clipboard

Is EIP2981 supported here

Open JacobInCode opened this issue 3 years ago • 4 comments

Is EIP2981 royalty standard supported here. Not seeing this in contracts.

JacobInCode avatar Sep 24 '21 18:09 JacobInCode

you can fork and try to implement it Have not seen EIP2981 anywhere implemented, supported or in use.

SimRunBot avatar Sep 25 '21 00:09 SimRunBot

How are royalties handled then?

On Fri, Sep 24, 2021 at 7:51 PM SimRunBot @.***> wrote:

you can fork and try to implement it Have not seen EIP2981 anywhere implemented, supported or in use.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Fantom-foundation/Artion-Contracts/issues/6#issuecomment-926984653, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFZYQ4ZPXM2CXULQT2Y2IB3UDUMKLANCNFSM5EWPEMWA .

JacobInCode avatar Sep 25 '21 04:09 JacobInCode

As Marketplace Royalties I think, go through here you will find the implementations.

https://github.com/Fantom-foundation/Artion-Contracts/blob/cf5aaf5acb402ee221abeec0f4b30975e2cca9de/contracts/FantomMarketplace.sol#L155

SimRunBot avatar Sep 25 '21 11:09 SimRunBot

Thanks for this. I think implementing royalties in this way is one of OpenSea's worst qualities - it makes sense for a centralized company but not for anybody trying to incentivize interoperability. EIP2981 solves this pretty well. Some implementations are sushi's shoyu and rarible protocols contracts. Am I missing something here or should I work on this?

JacobInCode avatar Sep 25 '21 16:09 JacobInCode