serilog-sinks-http
serilog-sinks-http copied to clipboard
FantasticFiasco
Refactor LogEventQueue when removing support for .NET Framework 4.5
I am wondering what the design choices are for the LogEventQueue. There are better options than rolling your own these days, mainly the Channel<T> class with ChannelReader<T> and ChannelWriter<T>. This might be overkill for this implementation, but any time I see code with a lock in it I try to think of alternative solutions.
Hi there and welcome to this repository!
A maintainer will be with you shortly, but first and foremost I would like to thank you for taking the time to report this issue. Quality is of the highest priority for us, and we would never release anything with known defects. We aim to do our best but unfortunately you are here because you encountered something we didn't expect. Lets see if we can figure out what went wrong and provide a remedy for it.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @erikmf12!
Are channels also supported on .NET Framework 4.5? Because I'm hesitant to use different implementations on different .NET versions. That wouldn't improve the testing story.
True, didn't think about that. I think .net framework version 4.6 is required with a nuget package.
I'm thinking about renaming this issue to Refactor LogEventQueue when removing support for .NET Framework 4.5. Whould that be ok for you?