search-bookmarks-history-and-tabs icon indicating copy to clipboard operation
search-bookmarks-history-and-tabs copied to clipboard

Add website icons?

Open dimateos opened this issue 2 years ago • 7 comments

Hey thanks for the extension, looking really good!

I feel like adding the site icon (maybe as an option) would help a lot to see at a glance the source of a search result. Basically, I consider more relevant a reddit icon at the left than the whole reddit url (I would keep it to see the matching substring etc).

Is it for a technical reason? I just like bookmarks with icons :)

Another comment (I didnt want to open multiple issues, but feel free to do so). Could the wheel click open tabs in the background directly without having to ctrl+click? It would be consistent with the rest of chrome.

Cheers

dimateos avatar Sep 26 '22 09:09 dimateos

Hi Dimateos,

thanks! Yes, I see your point and it would be a good addition to the extension. First I didn't add it because I did not want the extension to do any outside requests and keep it very minimalistic and fast. I would like to avoid that opening the search bar results in dozens of HTTP requests. But maybe those icons are already somewhere available in a cached form? At least it's worth a try, when I have some time to look into it.

Fannon avatar Sep 26 '22 09:09 Fannon

Great!

I dont know much about web/chrome, maybe the url site/favicon is already cached and it is just solved instantly. It could also be an option unset by default if it worries you.

Anyway thanks for looking into it whenever you have time!

dimateos avatar Sep 26 '22 10:09 dimateos

@dimateos : I've played around with this a little, but unfortunately there are quite a few challenges to make this work nicely.

First, I can't add a new permission 'favicon' without having the extension be disabled for all users after the update. I can make it an optional permission, but then I need to implement logic to ask for permission on demand (which would be a fair approach, though).

For tabs, I got it working, but for bookmarks and history it's a bit weird. Haven't found any official API documentation for this. Some old way of accessing it has been deprecated, but the new approach seems to not be fully worked out yet. Generally, if this extension is to work for all browsers, I'm not sure how well (and similar) the favicon feature would work across those.

This is how it could look like:

image

I'll keep this feature in mind, as it would be very nice. But unfortunately, to get this done properly I would need to invest more time.

Relevant Links / Material

  • https://docs.google.com/document/d/1ksvSq1zF-9jYSfGOvNluyoTV0Ud9xl6r9HiAKONqmz8/edit
  • https://bugs.chromium.org/p/chromium/issues/detail?id=104102

Fannon avatar Nov 12 '22 15:11 Fannon

I'm expecting the icon feature, too! Thank you!

gbsix avatar Feb 21 '23 02:02 gbsix

I'm expecting the icon feature, too! Thank you!

Yeah, it would be really nice. Would like to have it myself :)

But it looks like it might take some more time for the major browser makers to support this stable with the new Manifest v3 standard.

But other people are also asking for it. Seems like API documentation is completely missing. I could also just try around with examples, which were also not always in sync with each other. Confusing situation.

https://stackoverflow.com/questions/65846725/i-cant-find-any-documentation-for-chrome-favicon-api

Fannon avatar Feb 21 '23 20:02 Fannon

I'm expecting the icon feature, too! Thank you!

Yeah, it would be really nice. Would like to have it myself :)

But it looks like it might take some more time for the major browser makers to support this stable with the new Manifest v3 standard.

But other people are also asking for it. Seems like API documentation is completely missing. I could also just try around with examples, which were also not always in sync with each other. Confusing situation.

https://stackoverflow.com/questions/65846725/i-cant-find-any-documentation-for-chrome-favicon-api

I wonder if you could get some insights from this similar extension, github page. I used this ext before switching to yours, it's super fast and good to use, too.

gbsix avatar Feb 22 '23 02:02 gbsix

I often have a project that uses a gdoc for the summary, and gsheet for the data. I name them almost identically. This feature would really help clarify which match is the gdoc and which one is the gsheet.

I'll keep this feature in mind, as it would be very nice. But unfortunately, to get this done properly I would need to invest more time.

I would love to code to contribute but I also lack the time. I've seen other open source projects successfully attract talent with time available through bounties or tipjars. I'm not sure if this is something you're willing to consider.

Cheers!

paragbaxi avatar Oct 29 '23 15:10 paragbaxi