FalsePattern
Zig fmt parity [Report identation/formatting errors here!]
Expected Formatting:
pub fn logToFile(
comptime level: std.log.Level,
comptime scope: @TypeOf(.EnumLiteral),
comptime format: []const u8,
args: anytype,
) void {
const scope_prefix = "(" ++ switch (scope) {
std.log.default_log_scope => @tagName(scope),
else => if (@intFromEnum(level) <= @intFromEnum(std.log.Level.err))
@tagName(scope)
else
return,
} ++ "): ";
const prefix = "[" ++ comptime level.asText() ++ "] " ++ scope_prefix;
// Print the message to stderr, silently ignoring any errors
std.debug.getStderrMutex().lock();
defer std.debug.getStderrMutex().unlock();
const stderr = std.io.getStdErr().writer();
nosuspend stderr.print(prefix ++ format ++ "\n", args) catch return;
}
ZigBrains Formatting
pub fn logToFile(
comptime level: std.log.Level,
comptime scope: @TypeOf(.EnumLiteral),
comptime format: []const u8,
args: anytype,
) void {
const scope_prefix = "(" ++ switch (scope) {
std.log.default_log_scope => @tagName(scope),
else => if (@intFromEnum(level) <= @intFromEnum(std.log.Level.err))
@tagName(scope)
else
return,
} ++ "): ";
const prefix = "[" ++ comptime level.asText() ++ "] " ++ scope_prefix;
// Print the message to stderr, silently ignoring any errors
std.debug.getStderrMutex().lock();
defer std.debug.getStderrMutex().unlock();
const stderr = std.io.getStdErr().writer();
nosuspend stderr.print(prefix ++ format ++ "\n", args) catch return;
}
I'll repurpose this issue as a general zig fmt indentation / formatting mismatch tracker, it's easier to have everything in one place than having to open new issues every time.
Comments marked with a :+1: in this issue means that the specific formatting issues reported in that comment have been fixed.
Hi,
The formatting fix worked, but when the correct formatting is applied the coloration of the keywords is messed up.
I do not know if this is a ZigBrains issue, or something to do with Clion. But this issue only seems to appear when the code is formatted to comply with zig fmt. ie. after a Ctrl-S -> reformat.
Closing + reopening the file and restarting the LSP does not seem to fix the issue
- Spenser
It is indeed a zigbrains issue (weird race condition when applying the formatting and re-requesting syntax highlighting), i've also experienced it pretty consistently in my own projects
As a workaround, you can fix it by restarting the language server using the status icon circle.
I have it fixed in my local development branch, i think i'll be able to push a patch update this week, i just need to untangle it from the major feature update i'm working on.
EDIT: Fixed in 14.5.0
Fixed some more indent problems in 7231d1b6a26a4872058d7d0452d94b472012f5ae:
- Chained additions/bitwise operations/etc. split over multiple lines now indent properly
- Inline assembly indentation is now correct
- The closing bracket of a struct/union/enum will no longer occasionally have an extra unnecessary indent
It seems like formatting is working properly for the time being, i will close this issue for now, it can be reopened if the language changes and formatting breaks again.