Fallenbagel
feat: add tvdb indexer
Description
Screenshot (if UI-related)
To-Dos
- [x] Successful build
pnpm build - [ ] Translation keys
pnpm i18n:extract - [ ] Database migration (if required)
Issues Fixed or Closed
- Fixes #XXXX
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Any update on this feature? 👀
I think this would help with the issue described here https://github.com/Fallenbagel/jellyseerr/issues/648
Any update on this feature? 👀
I think this would help with the issue described here https://github.com/Fallenbagel/jellyseerr/issues/648
Sorry, I've got a lot of work at the moment but I've continued to work on it, I'm trying to use directly the api that sonarr uses, skyhook.
Looks like half of the tests are failing. Could you take a look and try to fix them? And add some for TVDB?
Looks like half of the tests are failing. Could you take a look and try to fix them? And add some for TVDB?
Hello, indeed, I solved the problem of the existing tests and I added tests for tvdb.
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.
@TOomaAh next time you should rebase instead of merge. Merging makes the history look messy.
It's also in our contributing guide to rebase instead of merging
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.
Hey @TOomaAh, I'm one of the Sonarr devs and this PR was recently brought to my attention.
I see that this is using Skyhook for TheTVDB data; our agreement with TheTVDB is for Skyhook to be hosted for Sonarr's direct use only and cannot be used with other applications as it's being used here.
@TOomaAh could you also remove the tvdb apikey setting? We will add a global one (i will personally commit it to this pr so just put a placeholder for now)
The reasoning for this decision can be found here: https://github.com/fallenbagel/jellyseerr/pull/1250#issuecomment-2589597226
@TOomaAh could you also remove the tvdb apikey setting? We will add a global one (i will personally commit it to this pr so just put a placeholder for now)
The reasoning for this decision can be found here: https://github.com/fallenbagel/jellyseerr/pull/1250#issuecomment-2589597226
No problem, I'll apply the change as soon as possible.
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.
Other applications require the user to provide a TVDB API key, or seemingly to host their own proxy endpoint like Skyhook as mentioned above, I assumed this was due to TVDB's policies - is this not the case?
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.
Hello! Is it possible for me to test this preview build?
Hello,
You'll have to be a bit more patient. This PR has not yet been reviewed by the jellyseerr team and the api key is missing for this PR to work. This shouldn't take long.
Got it. When the time comes, will there be a docker image tagged for this feature or do I have to build the codebase myself? What is the procedure for testing?
Also from a quick test, search is showing me both tmdb and tvdb result despite having set tvdb for just series:
In this example, Animaniacs is split into two series in TMDB, 1993 and 2020 version. However, TVDB treats both 1993 and 2020 version as one single series. Here when I search I am provided with the 1993 version with all the episodes of 2020 (from tvdb) and the 2020 TMDB modern version
TMDB should always be the default metadata scraper for all media types. TVDB should only be a user preference thing. By default Jellyseerr should always default to TMDB
@fallenbagel I disagree. Sonarr uses tvdb which frequently has issues with Jellyseerr because it uses tmdb for tv shows. This results in some things not being monitored and downloaded properly.
It's better to work with the appropriate metadata providers for both Radarr and Sonarr. Going against the grain only creates a worse experience for end users.
TMDB should always be the default metadata scraper for all media types. TVDB should only be a user preference thing. By default Jellyseerr should always default to TMDB
@fallenbagel I disagree. Sonarr uses tvdb which frequently has issues with Jellyseerr because it uses tmdb for tv shows. This results in some things not being monitored and downloaded properly.
We would prefer current behavior to not be changed.
Going against the grain only creates a worse experience for end users.
This PR introduces an optional preference for users to select TVDB as a metadata source. It is merely a few clicks away. Similar to how integrating with Sonarr or Radarr is optional, Jellyseerr does not require these services technically. Users can skip configuring them and still use Jellyseerr effectively, as the only required dependency is a media server.
Jellyseerr will continue to rely on TMDB as its default metadata provider, offering TVDB as an optional alternative. This option should give the end-user flexibility enough without altering the current default behavior.
TMDB will remain the default for now, even if this may not align with everyone’s preferences.
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.
What is the status on this? I think the last requested changes are already taken care of, right? I might be missing something
What is the status on this? I think the last requested changes are already taken care of, right? I might be missing something
Hello,
This PR is waiting for tests and a possible implementation of an internal proxy with a cache to prevent the tvdb api from being spammed.
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.
@TOomaAh I would love to test this out, how can I proceed? I have been wanting to have a requestor that matches the same data I see on Sonarr.
@TOomaAh I would love to test this out, how can I proceed? I have been wanting to have a requestor that matches the same data I see on Sonarr.
Hello,
Normally you just have to follow these instructions: https://docs.jellyseerr.dev/getting-started/buildfromsource
tests are failing, I'll solve the problem
Also, what language is used for the request to the TVDB API? Is there a setting for this, is some existing setting being used or is it just not being passed?