jellyseerr
jellyseerr copied to clipboard
Fallenbagel
Remove Jellyfin Password Reset
Description
When Reset Password is clicked, Jellyseerr redirects user to LAN IP and Port for Jellyfin.
Desired Behavior
Remove Option. User should reset password from Jellyfin UI.
Additional Context
Docker Bridged Network Reverse Proxy
Code of Conduct
- [X] I agree to follow Overseerr's Code of Conduct
~~The forget password will redirect to the external hostname if set though~~
Jellyseerr>settings>jellyfin>external URL? I have it pointing to my subdomain.
Jellyseerr>settings>jellyfin>external URL? I have it pointing to my subdomain.
Is this on stable release? I think I added the logic recently and did not release to stable yet
Is this fixed? I still see https://github.com/Fallenbagel/jellyseerr/blob/9252817b5823d70c551843b51158cdd3d57cd415/src/components/Login/JellyfinLogin.tsx#L284
I was going to post an issue on this, but seems it already exists. facing the same problem with latest docker release
I was going to post an issue on this, but seems it already exists. facing the same problem with latest docker release
Yeah the button will be removed (sorta forgot. No pun intended lmfao. I'll do it this week). Password resets should be done on jellyfin/jfa-go for jellyfin accounts
Gentle up on this issue :sweat_smile: To be honest I tried to take a look by myself to fix and use the external URL on the Forgot Password button, but I'm 100% newbie on this project and I didn't figure it out. But maybe I can try to submit a PR for removing the button if it can help ?
Gentle up on this issue :sweat_smile: To be honest I tried to take a look by myself to fix and use the external URL on the Forgot Password button, but I'm 100% newbie on this project and I didn't figure it out.
I actually forgot I was gon remove the button 😅
But maybe I can try to submit a PR for removing the button if it can help ?
Feel free to PR for a removal c:
The issue still persists, however it would be better to allow using a custom link for the button rather than hard linking it to [link]/web/index.html#!/forgotpassword.html. I'm using an LDAP server (Authentik) which handles user authentication and I direct my Jellyfin users to it to when they need to change/recover passwords.
The issue still persists, however it would be better to allow using a custom link for the button rather than hard linking it to [link]/web/index.html#!/forgotpassword.html. I'm using an LDAP server (Authentik) which handles user authentication and I direct my Jellyfin users to it to when they need to change/recover passwords.
~Current plans are to just remove the button.~
:tada: This issue has been resolved in version 1.8.0 :tada:
The release is available on:
-
v1.8.0 - GitHub release
Your semantic-release bot :package::rocket:
I'm running 1.8.1 (docker image) and the button is still there on the login page. I use Emby, when clicked, it takes you to the Emby password reset. If the button should be removable, I do not see a way to remove it. I chose to put the external url to https://127.0.0.1 :)
I think this reset button is a nice feature, but its only useful if the app/link it is redirecting you to is usefully working. More importantly, password resets can be a secuirty risk and thus, some people don't want this feature. (I had tp put a valid url in .... so I did).
@noybman it's not removed. The original post was to remove because it lead to a lan ip. It never used external ip. Now it uses external ip.
The original post was to remove it because it only used hostname and never external hostname. Now thats fix.
Going forward, we are not going to be removing the forgot password button. Instead an idea would be to add an option to hide it. Thus, this pr will be closed.