jellyseerr icon indicating copy to clipboard operation
jellyseerr copied to clipboard

fix: queue pageSize to get more than 10 downloading items in Servarr

Open Mavyre opened this issue 1 year ago • 3 comments

Allows to get all processing Series when entire seasons are downloded on Sonarr

Description

When downloading Season packs, Jellyseerr wasn't displaying all the downloading episodes due to Servarr default pageSize set to 10. 1000 should be a safe number to display correctly the processing items while downloading multiple Seasons (or season with >10 episodes) in parallel.

Screenshot (if UI-related)

Not UI related

To-Dos

  • [ ] Successful build pnpm build
  • [ ] Translation keys pnpm i18n:extract
  • [X] Database migration (if required)

Issues Fixed or Closed

None

Mavyre avatar Oct 28 '24 15:10 Mavyre

I've just spoken to Fallenbagel about it, and we think this should be a setting. As he said:

Requesting excessive data from a slow CPU or a system that may experience I/O bottlenecks could cause performance degradation

meaning that it can potentially cause problems if hundreds of downloads are in progress (retrieved from a seedbox, for example).

Could you please refactor this so it's an option in the Radarr/Sonarr settings?

Sure, but I'd have to check out Jellyseerr code a litttle bit more than just adding easily this option, to get things done properly. I'll need a more few weeks to have time to get into it.

Any help appreciated :)

Mavyre avatar Nov 13 '24 17:11 Mavyre

I've just spoken to Fallenbagel about it, and we think this should be a setting. As he said:

Requesting excessive data from a slow CPU or a system that may experience I/O bottlenecks could cause performance degradation

meaning that it can potentially cause problems if hundreds of downloads are in progress (retrieved from a seedbox, for example). Could you please refactor this so it's an option in the Radarr/Sonarr settings?

Sure, but I'd have to check out Jellyseerr code a litttle bit more than just adding easily this option, to get things done properly. I'll need a more few weeks to have time to get into it.

Any help appreciated :)

You'd want to add a number in the DVRSetting interface, then you can go in src/components/Settings/RadarrModal.tsx and src/components/Settings/SonarrModal.tsx to add the setting, and then get the pageSize setting from the place getQueue is called and pass it to the function.

gauthier-th avatar Nov 14 '24 12:11 gauthier-th

Hey @Fallenbagel,

Sorry, life has been busy lately! I'll do it next week-end and keep you posted!

Mavyre avatar Jan 15 '25 19:01 Mavyre

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

github-actions[bot] avatar Apr 08 '25 11:04 github-actions[bot]