Fallen-Breath
itemTooltipHideUntilMouseMove not working with Tweakeroo's shulker box preview in survival
Bug description
The MC Tweak "itemTooltipHideUntilMouseMove" doesn't work with the Tweakeroo tweak "tweakShulkerBoxDisplay" when in survival or adventure mode.
The vanilla tooltip disappears, but the shulker box preview still appears. The shulker box preview is still hidden as intended when in creative mode for some reason.
Steps to reproduce
- Set Tweakeroo's "tweakShulkerBoxDisplay" to True in the Tweak tab.
- Set Tweakeroo's "shulkerDisplayRequireShift" to False in the Generic tab (Optional, to make it easier to see).
- Set TweakerMore's "itemTooltipHideUntilMouseMove" to True in the MC Tweak tab.
- Get a shulker box with contents inside.
- Switch to survival mode.
- Place the shulker box in your inventory such that your mouse hovers over the shulker box as soon as you open your inventory.
- Open your inventory again without moving the mouse (Press Shift if required).
Expected behavior
The shulker box preview should not be visible.
Actual behavior
The shulker box preview is visible.
Relevant logs
No response
Minecraft version
1.21.4
TweakerMore version
3.24.1
Other information
This was tested with just Tweakeroo 0.23.2 and MaLiLib 0.23.2 installed, with no other settings changed.
Check list
- [x] I have verified that the issue persists in the latest version of the mod.
- [x] I have searched the existing issues and confirmed that this is not a duplicate.
This is kind of a feature request instead of a bug report, cuz itemTooltipHideUntilMouseMove only targets the vanilla tooltip
So, it works as intended
Oh, I just thought since it hides the preview in creative that it's unintended.
Figured out why this issue happens
This issue was introduced in the following commit: https://github.com/sakura-ryoko/malilib/commit/b4602a677ea3927d043a09a6b353d7ecfff356ff.
In this commit, the call to RenderEventHandler#onRenderTooltipLast for InventoryScreen was moved to a separate mixin, which caused the itemTooltipHideUntilMouseMove option to no longer be able to cancel the onRenderTooltipLast call. Although the cancellation was not intentional when implementing this feature, it's actually beneficial that it happens
Affected versions: malilib >= 1.21.3-0.22.0-sakura.4