python-onvif-zeep icon indicating copy to clipboard operation
python-onvif-zeep copied to clipboard

Wrong imports after merge pull request #10 from lucaszanella/zeep

Open iomihai opened this issue 7 years ago • 2 comments

Hello,

In onvif/client.py at lines 15-16 the imports do not work in python3.

from exceptions import ONVIFError
from definition import SERVICES

should be reverted to

from onvif.exceptions import ONVIFError
from onvif.definition import SERVICES

Thank you.

iomihai avatar Jan 22 '18 16:01 iomihai

Technically speaking you are not quite right too. I assume that orginal intention was to import modules relatively so to fix it should be:

from .exceptions import ONVIFError from .definition import SERVICES

tarelda avatar Mar 16 '18 19:03 tarelda

That would work better, I was just refering to the original imports that were replaced by that pull request.

iomihai avatar Mar 17 '18 08:03 iomihai