FakeFishGames
Oxygen tanks way too abundant on colonies
Disclaimers
- [X] I have searched the issue tracker to check if the issue has already been reported.
- [ ] My issue happened while using mods.
What happened?
This crewmate went around stealing and brought back like 80 something O2 tanks from a colony station
Reproduction steps
No response
Bug prevalence
Just once
Version
Other
-
0.18.11.0
Which operating system did you encounter this bug on?
I use Linux, by the way
Relevant error messages and crash reports
No response
In colony supply cabinets, there are 3x8 oxygen tanks
Very easy to steal without getting seen since colonies are huge
Tested on 0.19.0.0,
All tank holders generated with 3x1 tanks (not 3x8 tanks and such).
I couldn't find any oxygen tanks (4 from diving masks?) in the city outpost. I tried a few, but there was basically none now.
In other station types I could find around 10 or maybe 12 tanks (from 2 diving suit lockers with 3 spare tanks below them each, plus an odd diving mask perhaps in supply cabinets)
Are we intending to have virtually no oxygen tanks be the norm with the "City" type here as they don't tend to generate with any diving suits or oxygen shelves?
It seems to be that there's no diving suit containers, oxygen tank containers, or crew cabinets in the colonies. But there are supply cabs, which were missing the spawns. Fixed in Regalis11/Barotrauma-development@9902d35.
Tested against bugfixes commit https://github.com/Regalis11/Barotrauma-development/commit/9902d3587b6747866bdfdb51eff562ddd9a78602
For some reason every supply cabinet is starting with 3 stacks of 8 oxygen tanks. needless to say when I saw the first outpost I checked had 120+ oxygen tanks something seems very wrong.
This seems to be an issue of the actual sub files no and not auto item placement. its curious as I don't think I saw this before when testing on the dev branch but I see it on the bugfixes branch. there is likely some commit that bugfixes branch probably doesn't have causing this but I don't know which or if that's an issue.
as a further note though, very few oxygen tanks actually spawned from autofill (I think it was around 0-3 based on autoitemplacerdebug for city) so the probability may need a slight bump in my opinion.
it does concern me though that there are fixes to the outpost sub files that are fairly new (such as wiring fixes), while other branches may have different fixes to the same sub files (Like oxygen tanks removed from the cabinets to there isn't so many) which might not be an issue but is a possible concern.
@NilanthAnimosus The commit that removed the tanks from the cabinets is not present in bugfixes. This should be tested in dev.
I took a quick look at some of the colony modules, and couldn't find any tanks in any other cabinet than that specific one in DockingModule_01_Colony. @itchyOwl probably missed that one when removing the manually placed tanks from the modules. Fixed in https://github.com/Regalis11/Barotrauma-development/commit/0a4514e7b8478e89c1da06ee5ea0910b7cbd6df0
You also might want to look at both Engineering modules (not Colony)
Both of them have isolated, easy to steal Diving Suits + Oxygen Tanks, so every single outpost you get away with free resources Unless reputation/stealing is reworked in the future to be more punishing, perhaps remove the bottles and replace it with a disposable suit
