FakeFishGames
Items can be placed in non-interactable areas
- [*] I have searched the issue tracker to check if the issue has already been reported.
Description A portable pump can be placed in areas of the submarine where they cannot be interacted with after placement.
Steps To Reproduce
- Put a portable pump in your inventory
- Place it near an area where it appears that the pump can clip through solid walls or floors
- Attempt to interact with the pump with your mouse
Version v0.15.22.1 Windows 10 64-bit
Additional information I found this bug by accidentally placing a portable pump in the very bottom floor of the Humpback's "lower mid" section. After I placed it partially clipped through the sub I couldn't interact with it to pick it back up.
Changed the title, since this applies to all items that can be attached to walls, not just portable pumps
Addressed in https://github.com/Regalis11/Barotrauma-development/commit/4f425de8b1e9e24a56c575f3fc6461dd9b25249d
Tested against dev commit https://github.com/Regalis11/Barotrauma-development/commit/3f874d71a8cdc82d1d16314abdd6ae91f7e42098
Appears to work well in most areas such as flat walls, doors, areas you cannot reach and anything outside of wrench range. however on a Humpback submarine I noticed I could place it into a spot I could not retrieve with a wrench indicating some further work could be done (Likely due to sloped/curved structure pieces)?
Note I placed a relay in the rough area marked in the image below and could no longer select it.
Fixed in https://github.com/Regalis11/Barotrauma-development/commit/71b39c123d73612a052cf9a1585a3d28890cb9c0
Fixed items still being attachable inside walls in some cases (sloped walls in particular). Happened because we first did the raycast to find a position outside the wall and then rounded the position to the grid, which in some cases placed it inside a wall.
Tested against release commit https://github.com/Regalis11/Barotrauma-development/commit/56ddb502c58d91fea177e4f4c9b9c57bb12e7c8c, no issues found, closing.
Notes: Anywhere an attachable item could be placed that intersects a wall partially, can easily be removed by wrench. I could not find in any situation/shape where the item was no longer reachable via a wrench.