Hulling issues in subs/wrecks

[Tsunder]

• [x] I have searched the issue tracker to check if the issue has already been reported.

Description The hulls of vanilla subs/wrecks around glass / curved/sloped pieces is sometimes placed poorly - hull extending beyond the shell hitbox, causing gaps to not quite form properly, leading to issues like:

a) cutting the wall not causing breaches b) the breach being unboardable or very difficult to board from the outside (player and AI)

Subs it's on:

1. Kastrull command room

2. Hemulen command

3. Selkie Command

4. Hemulen Wreck

5. Kastrull Wreck

Steps To Reproduce

1. plasma cutting/breaching/boarding these areas from the outside

Version 0.15.13

Additional information Preferred fix would be collision boxes that match the shell curve (though that would slightly break many existing subs, maybe) but otherwise making the hulls be as much inside the hitbox as possible would be pretty good (example below)

[itchyOwl]

For information on how to fix it, see Regalis11/Barotrauma-development#2031.

[itchyOwl]

Addressed (finally) in Regalis11/Barotrauma-development@ac8d7bd (dev). Couldn't repro any issues with Hemulen or Selkie (possibly fixed in #8842), although the hulling isn't optimal. Found and fixed issues on Kastrull, Kastrull_Wrecked, and Venture (had to replace the front window with two pieces).

[NilanthAnimosus]

Tested against dev commit https://github.com/Regalis11/Barotrauma-development/commit/8650d05f17cee7897dfd96f0fbf0133fd6ad2f39

Only things I could find were:

• [x] Hemulen - One wall can be destroyed without the shuttle leaking (Doesn't seem like it would effect gameplay much but it is an inside to outside wall):

• [x] Venture - Rear section doesn't leak when breached at the middle and top diagonal walls:

[itchyOwl]

Fixed in Regalis11/Barotrauma-development@04fea39 (accidentally committed to bugfixes, cherry-picked to dev).

[itchyOwl]

Had to change that tail piece on Venture. Couldn't get it work.

[Tsunder]

if the hull doesn't leak when the shell is broken, doesn't that also mean creatures/humans can't swim from outside to in?

[NilanthAnimosus]

Tested Tested against dev commit https://github.com/Regalis11/Barotrauma-development/commit/4daf3d5b3220b598adde534f883c56bbddef4d3b

they now correctly form gaps that flood (and can be swam through etc all the same)

But on the Helmulen the linked hulls have a different room name than the ballast, and they have not been factored in for the neutral ballast level (0.4620 is the new value, the nav terminal has a value of 0.4930):

Additionally the small linked hulls have a roomname of RoomName.SubTopLeft instead of RoomName.Ballast and another room may be named a ballast over an airlock (?) or other room name (As below that hull is one named airlock without a hatch/door) - Its pumps are not tagged as a ballast though I've not checked the wiring I believe the room name is incorrect.

[itchyOwl]

Fixed the neutral ballast level and the hull names in Regalis11/Barotrauma-development@8e67387 (dev).

[NilanthAnimosus]

Tested against dev commit https://github.com/Regalis11/Barotrauma-development/commit/ca67f2830907ec7178c6011c2a94ef11ba98d2ca

The room names seem correct on the hemulen now, as well as the neutral ballast level. However I am noting the new hulls added also do not have any ambient light settings set - not sure if this is worth fixing but you can tell how extremely dark it is ambient lighting wise without that:

Additionally the top left smaller hull has no ambient lighting set as opposed to the top centre hatch and top right small hull from that which does:

[itchyOwl]

Fixed in Regalis11/Barotrauma-development@60c99ac (dev). Should have copied the hulls instead of creating new.

[NilanthAnimosus]

Tested against dev commit https://github.com/Regalis11/Barotrauma-development/commit/acd3623c058c74be8ae333e6733f8467f98eda1e, no issues found, closing.