Barotrauma icon indicating copy to clipboard operation
Barotrauma copied to clipboard

Multiple Dedicated servers (2) from same ipv4 seem to mess up master servers listing's

Open JoneKone opened this issue 4 years ago • 1 comments

  • [x] I have searched the issue tracker to check if the issue has already been reported.

Description Tried to spin up multiple dedicated servers different names (different ports) same ip (first server loses ping value on serverlist and second is not visible)

Steps To Reproduce spin up 2 dedicated server with own files from same ip.

Version v0.14.6.0

'''' additional info '' You can direct connect to the unlisted fine, the first one is visible on server list and you can connect to that 2.

JoneKone avatar Aug 09 '21 13:08 JoneKone

Fixed in https://github.com/Regalis11/Barotrauma-development/pull/3605/commits/d0ef7bc6d9e560aa6c6003bc641ca69f013838d4

Regalis11 avatar Oct 01 '22 10:10 Regalis11

Tested against serverlist-ping-fix commit https://github.com/Regalis11/Barotrauma-development/commit/95c040146060302b57b5c01dda76c63a2fd4ee31, no issues found

Notes: Before the fix on the same machine even (using both different port and query port per server instance): image

Same test with fix: image

I think this can be safely merged. but I've only tested this on my own machine (which still seems to be an improvement overall for the server list for both public servers).

NilanthAnimosus avatar Oct 10 '22 14:10 NilanthAnimosus

Moving to waiting as this is waiting to be merged

Rokvach avatar Oct 11 '22 08:10 Rokvach

Merged

Regalis11 avatar Oct 11 '22 13:10 Regalis11