FakeFishGames
Character flipping enhancements
Added "flipcharacter" status effect command to make a character flip. Mainly only useful for non-humanoids, for example, to make them spawn already flipped through some conditions.
Made "spawncharacter" status effect command and husk infection spawn the new characters already flipped if the target character is also flipped.
Made corpses spawned throughout the level have a 50% chance to spawn flipped.
I went ahead an implemented a fix to the flipping syncing bug in our private repo.
Fixed flipping monsters behaving inconsistently in multiplayer when controlling a monster: other clients saw the monster facing in the position of the cursor, even if it hadn't turned at all at the end of the client controlling it. There were two issues here:
Character.Control set the target dir based on the cursor position, disregarding if the character is a humanoid or a monster. The client controlling the monster reported the TargetDir of the monster to the server, but it doesn't do anything at the clients' end unless the monster moves. I think we can just report the actual direction the monster is facing as opposed to the direction it "wants to face".
I went ahead an implemented a fix to the flipping syncing bug in our private repo.
Fixed flipping monsters behaving inconsistently in multiplayer when controlling a monster: other clients saw the monster facing in the position of the cursor, even if it hadn't turned at all at the end of the client controlling it. There were two issues here: Character.Control set the target dir based on the cursor position, disregarding if the character is a humanoid or a monster. The client controlling the monster reported the TargetDir of the monster to the server, but it doesn't do anything at the clients' end unless the monster moves. I think we can just report the actual direction the monster is facing as opposed to the direction it "wants to face".
Can I reduce the contents of this PR to just the additions rather than fixes then? Namely, making a spawned character spawn already flipped if the character triggering the status effect or husk infection transformation is also flipped, as well as a status effect command to manually flip a character, in case we want to flip them in certain occasions, such as when spawning in.
That sounds good, those seem like useful additions and I can't see any major problems in those changes.