Faithcaio

`NetHandlerPlayServer#processClickWindow` just sends the unmodified inventory back to the client. That is why we have no event that fires. There are no changes. Not sure how to handle this...

We always fire the inventory events AFTER changes happened. So we would need a new event for this. Maybe smth. like `ClickInventoryEvent.Spectator` but not extending ClickInventoryEvent as we cant provide...

^ API9

Delaying is the way to go. Closing/Opening inventories during the callbacks cannot work. see also https://github.com/SpongePowered/Sponge/issues/3420

I think the issue is coming from `CommandSourceStackMixin_API` then. There is no `Subject` in the cause and it then picks the system subject instead of forwarding `CommandSource.NULL` from `ServerFunctionLibrary`

Should this not check if it actually is attached? e.g. with (LadderBlock#canSurvive) Ladders can at least temporarily not be attached to anything.

may be related to https://github.com/SpongePowered/Sponge/commit/29095050dc3aac26b48849120592306d71601255 does it happen with the previous build (1130) too?

How can the NBTTranslator know how to serialize your value? It does not know that it belongs to a registry.

This works for types registered in `SpongeDataManager#findRegistryTypeFor`

What we're doing is allowing plugins to set KEEP_INVENTORY for an individual user on death. So the bug is probably this then: https://github.com/SpongePowered/Sponge/blob/3e618117627c3557e29e32ed35681033b3d07cc9/src/main/java/org/spongepowered/common/event/tracking/phase/entity/EntityDeathState.java#L126 Calling the Sponge event always causes the...