reckoner icon indicating copy to clipboard operation
reckoner copied to clipboard

A few fixes

Open rbren opened this issue 1 year ago • 3 comments

This PR fixes https://github.com/FairwindsOps/reckoner/issues/690 and https://github.com/FairwindsOps/reckoner/issues/689, as well as an issue handling errors with templating

Checklist

  • [x] I have signed the CLA
  • [x] I have updated/added any relevant documentation

Description

What's the goal of this PR?

fix the issue above

What changes did you make?

  • handled an err that wasn't being returned
  • switched to helm dependency build instead of helm dependency update

What alternative solution should we consider, if any?

rbren avatar Oct 21 '24 20:10 rbren

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 21 '24 20:10 CLAassistant

I can't repro https://github.com/FairwindsOps/reckoner/issues/689 locally sadly. Let's see if this fixes it

rbren avatar Oct 21 '24 20:10 rbren

actually pretty clear what the issue is, fixed it

rbren avatar Oct 21 '24 20:10 rbren