goldilocks icon indicating copy to clipboard operation
goldilocks copied to clipboard

Summary elements shouldn't contain headings

Open thewildmage opened this issue 3 years ago • 0 comments

What happened?

Back when I did the big UI refresh, I foolishly put a bunch of <h2> elements inside <summary> elements. In some setups, this could result in the headings losing semantic meaning, an accessibility loss (see MDN Docs: <summary>: The Disclosure Summary element: Summaries as headings).

What did you expect to happen?

<h2> elements should be moved outside of the <details> elements, and new text should be provided for the <summary> elements.

This update also provides the opportunity to make the <details> elements simpler and more visually consistent in all places they're used by removing the custom styling and icons.

These changes might look something like this: Mock-up of suggested changes.

How can we reproduce this?

All versions since v3.1.0 are affected by default. There are no steps necessary to reproduce beyond just "use Goldilocks."

Version

v3.1.0+

Search

  • [X] I did search for other open and closed issues before opening this.

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

Additional context

No response

thewildmage avatar Aug 16 '22 18:08 thewildmage