FairRoot

FairRoot copied to clipboard

This issue is dedicated to discuss how we should write (or improve) getter functions in FairRoot. From the discussion with @dennisklein in PR #1254, we found it's very inconvenient to...

YanzhaoW

CTest errors fail to be caught by the CI workflow

1

**Describe the bug** Multiple crashes in ctests are not caught by the CI workflow. ### Unused file source in run_reco_timebased.C https://github.com/FairRootGroup/FairRoot/blob/fa7108b45684c729c2e88b12d7fbf4bbb5a4dc65/examples/advanced/Tutorial3/macro/run_reco_timebased.C#L42-L48 Here even though the file source `fFileSource` is initialised,...

YanzhaoW

Create `FairBaseTypes.h`

6

Created `namespace FairRoot` with `struct EntryID {size_t fId;}`. Should replace PR #1405. --- Checklist: * [x] Followed the [Contributing Guidelines](https://github.com/FairRootGroup/FairRoot/blob/dev/CONTRIBUTING.md)

karabowi

Ownership semantics of `FairRootManager::GetObject`

7

- [ ] Analyze usage in FairRunAnaProof, FairRunOnline of GetObject - #1369 - #1396 https://github.com/FairRootGroup/FairRoot/blob/12f519f8054d50d0d0edc345878f93a8b76a9699/fairroot/online/steer/FairRunOnline.cxx#L221 - [ ] Cleanup FairRootManager and GetObject - #1353 - #1354 - #1402 - [...

ChristianTackeGSI

FairRunAna::Run() unclear description

1

**Is your feature request related to a problem? Please describe.** Current implementation of `FairRunAna::Run()` does not match the description. What we have now in `FairRunAna` is: ``` /**Run from event...

karabowi

Create EventDisplay test

4

**Is your feature request related to a problem? Please describe.** We do not have any test for event display. Naively adding such test results in: ``` Command: "/Users/karabowi/fairroot/dev/build_oct22rc_mt_D21.5_c13.1/examples/advanced/Tutorial3/macro/eventDisplay.sh" ""TGeant4"" Directory:...

karabowi

Hi, again I'm trying to use XML to remove configuration of tracks/detectors from FairRoot Event Display Mention any issue this PR resolves or is related to. --- Checklist: * [...

DanielWielanek

(Copied from https://github.com/FairRootGroup/FairRoot/pull/1028#issuecomment-916839687 by @dennisklein) Individual parts of this list can be handled in dedicated PRs or Issues. I suggest to follow up on this by: * [ ] Rebase...

ChristianTackeGSI

**Is your feature request related to a problem? Please describe.** Our CMake related documentation is really not perfect. **Describe the solution you'd like** Provide some documentation. Maybe in doxygen? `cmake/cmake.dox`...

ChristianTackeGSI

Protobuf compiler version 3.20.1 doesn't match library version 3.12.4

3

**Describe the bug** __I have installed FairSoft, and declare SIMPATH_ _Next step is to install FairRoot following the steps describe there : https://github.com/FairRootGroup/FairRoot/tree/dev I first have a warning while doing__...

audreychatillon