Move FairModule::fAllSensitiveVolumes to FairRunSim

[ChristianTackeGSI]

Instead of using a thread local, let's use something that is tied to the "simulaion session" (as noted in some places).

FairRunSim has all the Modules anyway, so let it also have the list of sensitive Volumes.

OR should we move it to FairMCApplcation instead?

---

Checklist:

• [X] Followed the Contributing Guidelines

[coderabbitai[bot]]

Walkthrough

Walkthrough

The recent updates to the FairRoot framework focus on centralizing the management of sensitive volumes within simulations. By adjusting how sensitive volumes are accessed and managed, specifically moving towards using the FairRunSim instance for handling these volumes, the framework enhances modularity and encapsulation. This shift is evident in the removal of direct access to sensitive volumes in FairModule and the inclusion of sensitive volume management within FairRunSim, streamlining interactions across different components of the framework.

Changes

Files	Change Summary
.../sim/FairDetector.cxx, .../sim/FairModule.cxx	Added FairRunSim.h include. Modified access to fAllSensitiveVolumes through FairRunSim::Instance() and updated instantiation and header usage in FairModule.cxx.
.../sim/FairMCApplication.cxx	Updated iteration over sensitive volumes to use an instance member of FairRun instead of a static member.
.../sim/FairModule.h	Removed includes for TRefArray, vector, and the declaration of fAllSensitiveVolumes, indicating a shift in handling sensitive volumes.
.../steer/FairRunSim.h	Added declarations for FairVolume and a vector of FairVolume pointers for managing all sensitive volumes, along with adding FairModule, FairDetector, and FairMCApplication as friend classes.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.