FairRoot icon indicating copy to clipboard operation
FairRoot copied to clipboard

`FairModule::AddSensitiveVolume` searches volume set twice

Open dennisklein opened this issue 4 months ago • 0 comments

https://github.com/FairRootGroup/FairRoot/commit/386912ebcc7877927980cbbf7ef46a32dddc3e4b introduced a double linear search of the volume on vList in FairModule::AddSensitiveVolume:

  1. search happens here
  2. search happens here, see FairVolumeList::addVolume

Possible fix involves changing the error behaviour of FairVolumeList::addVolume to return the failure to add to the caller, e.g. by returning a pointer to the added volume (which is nullptr in case of not adding it).

dennisklein avatar Mar 03 '24 13:03 dennisklein