FairRoot
FairRoot copied to clipboard
`FairModule::AddSensitiveVolume` searches volume set twice
https://github.com/FairRootGroup/FairRoot/commit/386912ebcc7877927980cbbf7ef46a32dddc3e4b introduced a double linear search of the volume on vList
in FairModule::AddSensitiveVolume
:
- search happens here
- search happens here, see
FairVolumeList::addVolume
Possible fix involves changing the error behaviour of FairVolumeList::addVolume
to return the failure to add to the caller, e.g. by returning a pointer to the added volume (which is nullptr
in case of not adding it).