factory_boy icon indicating copy to clipboard operation
factory_boy copied to clipboard

Comments should match the parameter names

Open cclauss opened this issue 3 years ago • 2 comments

cclauss avatar Oct 05 '22 15:10 cclauss

Good catch! Can you investigate why the "examples" check fails?

Thanks :)

rbarrois avatar Oct 05 '22 17:10 rbarrois

This failure appears to be unrelated to editing a docstring. https://github.com/FactoryBoy/factory_boy/blob/master/examples/flask_alchemy/test_demoapp.py#L14 seems to be failing to create a database because it is being run outside of a Flask application context. I test using pytest to avoid such confusing situations.

cclauss avatar Oct 05 '22 17:10 cclauss

@cclauss sorry i wasn’t clear enough, the CI issue you encountered has been fixed on master. This change is still very much needed. Apologies.

kingbuzzman avatar Oct 27 '22 11:10 kingbuzzman