sbox-issues icon indicating copy to clipboard operation
sbox-issues copied to clipboard

[Animgraph] Aim Matrix increments incorrectly.

Open badandbest opened this issue 2 years ago • 5 comments

Describe the bug

The Aim Matrix is a 3x4 matrix, S&box divides the poses to fit within -45° and 45°.

I have recreated how the Aim Matrix divides these poses. image

The most glaring issues are that:

  • image is not at 0° pitch.
  • Straight Up is at a pitch of 45°, instead of 90°.

To Reproduce

  1. Set up an Aim Matrix node. image
  2. Aim 45° up.

It will now play the Straight Up pose, instead of the Up Center pose.

Expected behavior

Aim Matrix is a 3x4 matrix. Straight Up should require a second increment like this 2DBlend example, taken from Team Fortress 2. image

Media/Files

No response

Additional context

This is a S&box specific issue. In Half Life: Alyx it works as you'd expect.

badandbest avatar May 06 '23 20:05 badandbest

Please it's been over 100 days

badandbest avatar Aug 20 '23 12:08 badandbest

Please it's been over 200 days

badandbest avatar Nov 22 '23 09:11 badandbest

Can you explain this to me like I'm a 5 year old please. Is this in animgraph?

garrynewman avatar Nov 23 '23 07:11 garrynewman

Yes! Sorry, should have specified that more clearly.

Something about the node's math is wrong.

https://github.com/sboxgame/issues/assets/91832803/9535dc7f-733a-40a1-b9ee-8b84a62a97ce

animgraph file.zip

I should also make it clear that this is not a problem with the citizen animations.

badandbest avatar Nov 23 '23 10:11 badandbest

1 year anniversary 🎉

A lot of the systems in s&box are being remade for scenes. Will the animgraph get the same treatment? And if so, would it even be worth keeping this issue up?

badandbest avatar May 07 '24 10:05 badandbest

This should be working correctly now, for both 3x4 and 3x5 (Can look straight down is 3x5) @badandbest

aylaylay avatar Jun 16 '24 08:06 aylaylay

Holy shit it works

https://github.com/Facepunch/sbox-issues/assets/91832803/8c6a75ce-e5e0-4494-b26f-ae8a53a4c371

badandbest avatar Jun 16 '24 09:06 badandbest