garrysmod icon indicating copy to clipboard operation
garrysmod copied to clipboard

Published 20 hours ago • verified publisher icon Facepunch

Weapons and entities now copy their userdata and metatables

Open Kefta opened this issue 8 years ago • 4 comments

Deep copies are now made of weapons and entities in Get. Also, BaseClass keys are no longer set in any table except the base SWEP/ENT table. Lastly, the SWEPs base is now set in Register. Matrices are not copied due to https://github.com/Facepunch/garrysmod-requests/issues/880, but the code to do so is sitting in a comment.

Kefta avatar Dec 21 '16 07:12 Kefta

This has conflicts, it seems.

mcNuggets1 avatar May 19 '19 14:05 mcNuggets1

No clue why the diff is so messy, but a bit annoying constantly resolving conflicts for PRs ignored for years.

Kefta avatar May 19 '19 15:05 Kefta

I assume line-ending changes are the culprit for the diff mess. (which should count as whitespace change, try the diff option to ignore those)

neico avatar May 20 '19 01:05 neico

Yeah I noticed that when ignoring them after I made the change, but I resolved the conflicts through the GitHub editor which I assumed would maintain line endings.

Kefta avatar May 22 '19 14:05 Kefta

Closing due to lack of activity.

robotboy655 avatar Jan 12 '23 14:01 robotboy655

Reopen and I'll fix, sorry I didn't notice this one

Kefta avatar Jan 12 '23 16:01 Kefta

It's been enough time. You can open a new one if you ever get around to it.

robotboy655 avatar Apr 17 '23 17:04 robotboy655

Yeah I started rewriting this and got distracted, I'm gonna go with a different solution so a new PR would be better

Kefta avatar Apr 17 '23 17:04 Kefta