garrysmod-requests icon indicating copy to clipboard operation
garrysmod-requests copied to clipboard

Raise `VOICE_NUM_CHANNELS` to allow for more player to talk simultaneously

Open RaphaelIT7 opened this issue 9 months ago • 1 comments

Details

Currently, VOICE_NUM_CHANNELS is set to 5 allowing for up to 5 players to talk at the same time, but on servers with more slots it can easily happen that more than 5 players talk. If that happens, only the first 5 players will be auditable and anyone else simply can't be heard.

It wouldn't require any net compat changes, as it's purely a client-side thing. I would suggest raising it to 16 as it should be able to handle it, and it should be fully enough. The networking should be able to handle it (it already does as everything is already networked, it just can't be played), especially if https://github.com/Facepunch/garrysmod-requests/issues/2632 is done.

What happens if more than 5 players talk: Image

Where VOICE_NUM_CHANNELS is defined: https://github.com/RaphaelIT7/obsolete-source-engine/blob/gmod/engine/audio/private/voice_sound_engine_interface.h#L22-L23

RaphaelIT7 avatar Feb 28 '25 00:02 RaphaelIT7

I've never been aware of this limitation, have my years of hearing tons of player scream on DarkRP servers all been a lie...

xCynDev avatar Mar 15 '25 06:03 xCynDev