fabulously-optimized icon indicating copy to clipboard operation
fabulously-optimized copied to clipboard

MoreCulling

Open Madis0 opened this issue 2 years ago • 19 comments

CurseForge link

https://www.curseforge.com/minecraft/mc-mods/moreculling

CurseForge Mod Distribution

Allowed

Modrinth link

https://modrinth.com/mod/moreculling

Source/other link

https://github.com/fxmorin/moreculling

What it does

Culls various non-full blocks

Why should it be in the modpack

Culling does help performance, as evident by Sodium, Entity Culling, Cull Less Leaves etc

Why shouldn't it be in the modpack

  • Performance boosts are not proven yet (tests are inconclusive)
  • CIT is broken in item frames
  • Several mods have incompatibilities

Categories

Performance optimization

Additional details

No response

Madis0 avatar Jun 03 '22 15:06 Madis0

I just did some testing and I did indeed had an incredible boost in performance, with over 800 FPS with 32 render distance, when before I had about 200-300

YumatanGames avatar Jun 03 '22 23:06 YumatanGames

I had a crash caused by this More Culling. Seems to be a conflict with Iris.

YumatanGames avatar Jun 04 '22 04:06 YumatanGames

I had a crash caused by this More Culling. Seems to be a conflict with Iris.

Alright, you can report it to the mod dev. Overall there is no reason to report bugs here yet as the mod is in alpha (and the label here is WIP). When that changes, I'll actually consider adding it and will care about any potential bugs.

Madis0 avatar Jun 04 '22 05:06 Madis0

The CF upload exist and is going to be fixed, because it's not working at the moment. (See also https://github.com/fxmorin/MoreCulling/issues/19#issuecomment-1154344176)

RaptaG avatar Jun 13 '22 16:06 RaptaG

Vouch. Though note at the current moment this crashes with CullLessLeaves. A fix is being worked on.

isXander avatar Jun 14 '22 21:06 isXander

Works with Cull Leaves as far as I've noticed (predecessor of CullLessLeaves)

FireTner avatar Jun 26 '22 08:06 FireTner

Works with Cull Leaves as far as I've noticed (predecessor of CullLessLeaves)

Yeah this is known, Cull Leaves works but CullLessLeaves doesn't (it's gonna be fixed soon though).

RaptaG avatar Jun 26 '22 08:06 RaptaG

Officially no longer in Alpha. https://modrinth.com/mod/moreculling/version/v0.4.0 Has automated curseforge releases. Also drastically culls item frames now xD CullLessLeaves also already has a partial fix, some further fixing is required

FxMorin avatar Jul 03 '22 03:07 FxMorin

Does not crash with CullLessLeaves as of https://github.com/isXander/CullLessLeaves/commit/55112fc3a8abbb6f267682fd74723e6b29c574d3 (the new version of CullLessLeaves is unreleased though).

RaptaG avatar Jul 08 '22 09:07 RaptaG

CurseForge link: https://www.curseforge.com/minecraft/mc-mods/moreculling

RaptaG avatar Jul 08 '22 09:07 RaptaG

Also Sodium Configuration is now a thing in MoreCulling

RaptaG avatar Jul 09 '22 17:07 RaptaG

Compat version of CLL released

RaptaG avatar Jul 10 '22 11:07 RaptaG

LambdaBetterGrass seems to be unsupported (see https://github.com/fxmorin/MoreCulling/discussions/31#discussion-4209006)

RaptaG avatar Jul 12 '22 10:07 RaptaG

LambdaBetterGrass seems to be unsupported (see fxmorin/MoreCulling#31 (comment))

Yeah, but it says it won't crash and some optimizations are supported. Please test the mod with FO to see if there are any more conflicts.

Madis0 avatar Jul 12 '22 10:07 Madis0

For people who say performance doesn't improve: you aren't in an environment where it is improved. It culls things like bamboo, item frames, chorus fruit etc. You have to test in jungles or end islands.

isXander avatar Jul 15 '22 13:07 isXander

People are currently seeing inconsistent results and after talking with the dev, the issue is likely due to LambdaBetterGrass not being supported yet. Postponing this for later.

Edit: an update is released that should fix it, so you can continue testing

Madis0 avatar Jul 18 '22 13:07 Madis0

As you said, v.0.5.2 fixed it (see https://github.com/fxmorin/MoreCulling/commit/73fc5dd978ae617416d4af4c53d7c76f41b1d10b)

RaptaG avatar Jul 19 '22 10:07 RaptaG

Performance testing results were inconclusive, some mods had incompatibilities. Decided not to add it for 4.2.0 yet, but keeping an eye on it for the future.

Madis0 avatar Aug 15 '22 16:08 Madis0

0.10.0 added a separate toggle for mods, so at least that could be disabled.

Madis0 avatar Aug 27 '22 09:08 Madis0

new comment in #424

Julienraptor01 avatar Nov 25 '22 15:11 Julienraptor01

Updated to 1.19.3!

New Features:

  • Cloud Culling
  • Map Culling (in item frames)

Fixes: Modded blocks where not correctly being excluded from being culled

Seems worthy of a retry, could replace #512 too.

Madis0 avatar Dec 11 '22 07:12 Madis0