fabulously-optimized icon indicating copy to clipboard operation
fabulously-optimized copied to clipboard

ThatOrThis

Open Madis0 opened this issue 4 years ago • 5 comments

Mod name

ThatOrThis

Curseforge link

No response

Other links

https://modrinth.com/mod/thatorthis https://github.com/EZForever/ThatOrThis

What it does

Allows defining a list of alternative mods

Why should it be in the modpack

So people who only want to swap a mod or two can enjoy the modpack, having the management in-game is better than CF/MMC/packwiz options as it is launcher-agnostic

Why shouldn't it be in the modpack

Not in CF, needs the jars to be bundled for now (direct downloads are planned), need to understand how it works, probably needs more time to stabilize the mod (looking at the todo and breaking changes already)

Categories

New feature

Additional details

Possible options:

  • Iris+Sodium vs Canvas
  • WI Zoom vs Ok Zoomer vs Logical Zoom
  • Phosphor vs Starlight
  • Custom Fog
  • MCPPPP + related mods
  • Enhanced Block Entities vs Better Beds + FastChest
  • Experimental mods like C2ME

Madis0 avatar Aug 27 '21 12:08 Madis0

Well it doesn't seem to fit for people who are smart enough to handle the mods folder but good for people who are dependent on GUI and doesn't know much about the mod folder Well overall it will be good to add

Rajbir98 avatar Sep 02 '21 10:09 Rajbir98

Another idea: MCPPPP+Chime+etc vs CIT Resewn+etc

MulverineX avatar Sep 06 '21 16:09 MulverineX

Shame that this mod hasn't been updated in a while... It would be cool to have an option for canvas in the pack. Recent updates have made canvas really performant, sometimes surpassing sodium performance. It's also more compatible with other mods and has some shader features built in (e.g. bloom, wavy leaves, shadows).

supsm avatar Sep 23 '21 00:09 supsm

Sounds like a good mod to have options for people to choose if they want unstable mods, like c2me.

CodeF53 avatar Nov 06 '21 16:11 CodeF53

Sounds like a useful mod for bigger modpacks like this one.

nsde avatar Jan 16 '22 19:01 nsde

UPDATE: This mod hasn't been updated in about a year now. I think we can close this issue for now!

nsde avatar Sep 10 '22 17:09 nsde

This seems like it might be useful, but it hasn't been updated in a long time and is still on MC 1.17.1 which we don't support anymore, so I'm going to close this for now but feel free to reopen it.

osfanbuff63 avatar Sep 10 '22 17:09 osfanbuff63

Looks like another dev might be picking this up https://github.com/SettingDust/ThatOrThis . atm this is only updated to 1.18 though.

MulverineX avatar Sep 10 '22 18:09 MulverineX

Yeah, but even if it was updated to 1.19, it also needs the aforementioned features and that seems unlikely to happen for a direct port fork. I'll reopen when that ever does happen.

Madis0 avatar Sep 10 '22 18:09 Madis0

Halo. Not we don't want to update. The newer fabric rewrite the strategy for loading mods. And the newer java not allowed access the same package name classes from another jar. So that we can't use the hacking method to decide which mod we need. We have to wait for fabric xd

Related: https://github.com/FabricMC/fabric-loader/issues/682

SettingDust avatar Nov 06 '22 03:11 SettingDust

Fair enough. At this point I think any hack is too fragile (vs https://github.com/EZForever/ThatOrThis/issues/18, which apparently seemed impossible too?) so it's better just to accept that this cannot be implemented in a clean way.

Madis0 avatar Nov 06 '22 07:11 Madis0

Maybe the quilt can implement this. I'll looking into that instead of fabric that an issue related exists for so long time(3y?)

Edit: Quilt can implement that. :)

SettingDust avatar Nov 06 '22 09:11 SettingDust

Finally, I rewrite it as ModSets https://github.com/SettingDust/ModSets

SettingDust avatar Jul 20 '23 07:07 SettingDust