yarn icon indicating copy to clipboard operation
yarn copied to clipboard

<STRUCTURE>_HAS_STRUCTURE biome tag fields should be renamed to HAS_<STRUCTURE>

Open TelepathicGrunt opened this issue 1 year ago • 2 comments

Example of what I am seeing in 1.20 Yarn BiomeTags class: image

Personally, I feel this is a cause where it should break out of the <inner_tag>_<outer_folder> format in favor of cleaner readability.

In this case, I propose HAS_<inner_tag>. Or HAS_STRUCTURE_<inner_tag> which still reads better that current situation

TelepathicGrunt avatar Sep 10 '23 19:09 TelepathicGrunt

Another possible format is HAS_<inner_tag>_STRUCTURE just for completeness.

So

HAS_STRONGHOLD HAS_STRONGHOLD_ STRUCTURE HAS_STRUCTURE_STRONGHOLD

Just should ideally start with HAS_

TelepathicGrunt avatar Sep 10 '23 20:09 TelepathicGrunt

FYI, these names are automatically generated in this format by name-proposal. The mappings for that class look pretty empty: https://github.com/FabricMC/yarn/blob/b0581c68220cc4fe9247584984b7395b37e6cf4b/mappings/net/minecraft/registry/tag/BiomeTags.mapping#L1-L3

Juuxel avatar Sep 10 '23 20:09 Juuxel