yarn icon indicating copy to clipboard operation
yarn copied to clipboard

Context parameters should not be abbreviated

Open haykam821 opened this issue 4 years ago • 1 comments

Context parameters such as ctx should be changed to context:

https://github.com/FabricMC/yarn/blob/bb92d40dd0f91d62569d60ac73b2438ae7c4b29d/mappings/net/minecraft/block/DoorBlock.mapping#L19-L20

Yarn conventions state that most abbreviations should be avoided. The respective class names (ItemPlacementContext, LootContext, etc.) are not abbreviated as well.

haykam821 avatar Dec 23 '21 18:12 haykam821

Imo ctx should only exist as lambda params, especially when in conflict with outer local var

liach avatar Dec 29 '21 16:12 liach