Floors and ceilings are not walls

Open haykam821 opened this issue 4 years ago • 1 comments

Currently, the WallMountLocation enum and Properties.WALL_MOUNT_LOCATION field are used for the face property, which has three values: floor, wall, and ceiling.

It is quite clear that floors and ceilings are not walls, but the mappings seem to think this:

https://github.com/FabricMC/yarn/blob/e0df689e614bd476818c601bd04307194f310159/mappings/net/minecraft/state/property/Properties.mapping#L170-L171

Would it be better to simply rename both mappings to 'face'? Is another name more descriptive and thus better?

Nov 12 '21 01:11 haykam821

I would rename it to block. only connects to blocks or other walls. Even though face could also be good.

Nov 22 '21 13:11 zOnlyKroks