yarn icon indicating copy to clipboard operation
yarn copied to clipboard

Use the registered names for Registry.MOB_EFFECT and Registry.MENU

Open Juuxel opened this issue 4 years ago • 1 comments

The registries are currently called STATUS_EFFECT and CONTAINER. I think we should use the registered names for every registered object, which includes Registry.MENU and Registry.STATUS_EFFECT as well.

(This change was originally part of #1048, but I took it out because it's a major change compared to the other changed names.)

Juuxel avatar Jan 12 '20 19:01 Juuxel

I disagree. Let's look at the registry key for world and dimension(options). Both have the same instance, yet they are kept in different fields and cannot be assigned to each other due to different generic types. Mojang definitely ain't using the registered names for one of these two fields.

liach avatar Mar 28 '21 02:03 liach