tiny-remapper icon indicating copy to clipboard operation
tiny-remapper copied to clipboard

Remapping deletes duplicate classes from jars

Open Juuxel opened this issue 3 years ago • 1 comments

See example project: https://github.com/Juuxel/duplicate-mods

  • There are two mod dependencies, a.jar and b.jar
    • a.jar has classes A, B
    • b.jar has classes A, B, C, D
  • When you build the project with gradlew classes, Loom will remap the mods
  • If you take a look in .gradle/loom-cache/remapped_mods, only one of the jars will have the classes A, B even though both inputs have them

This is a simplified test case from a real-life mod setup where a crossplatform mod shadows some of its modules but still depends on the other modules in its POM.

Juuxel avatar Oct 12 '22 22:10 Juuxel

Fixing this requires a change on tiny remappers side of things. I will move this issue to that repo.

At the very least I think it should bail out in this case?

modmuss50 avatar Dec 09 '22 22:12 modmuss50