fabric icon indicating copy to clipboard operation
fabric copied to clipboard

ArmorMaterial identifier is not mod dependent

Open Siphalor opened this issue 5 years ago • 5 comments

I just noticed that when registering new armor materials, their name is not an Identifier. This leads to the strange situation that when implementing own armor sets Minecraft will always search minecraft:textures/models/armor for their 3d texture.

Shouldn't Fabric API have an interface for this or at least gain the correct namespace by the item's id?

Siphalor avatar Feb 20 '19 15:02 Siphalor

Parsing the Strings as Identifiers might be easier.

asiekierka avatar Feb 20 '19 15:02 asiekierka

Is this ever going to be worked on again? My original pr (#98) was closed with the note that this is being worked on?!

Siphalor avatar Feb 16 '20 20:02 Siphalor

I dont see why not, sadly I dont know what asie's idea was.

modmuss50 avatar Feb 16 '20 20:02 modmuss50

See #963

i509VCB avatar Aug 10 '20 09:08 i509VCB

This is still an issue in 1.19. While originally resolved in #963 with the armor texture API, it was never included in the 1.17 branch for some reason. Instead, it got replaced with a new armor rendering registry (#1607) that only lets you do fully custom rendering instead of just providing mod-dependent texture paths.

Juuxel avatar Aug 15 '22 12:08 Juuxel