fabric icon indicating copy to clipboard operation
fabric copied to clipboard

[Issue] - Fix HudElementRegistry.replaceElement() for subtitles during gameplay.

Open Liam-Broome opened this issue 1 month ago • 6 comments

Fixes issue #4933 where HudElementRegistry.replaceElement(VanillaHudElements.SUBTITLES, ...) did not work correctly during normal gameplay, only when the game was paused. This prevented mods from properly scaling, positioning, or otherwise modifying subtitle rendering during active play.

https://github.com/user-attachments/assets/501116a1-6d37-4a04-8476-71be2870bd8e

Liam-Broome avatar Nov 19 '25 16:11 Liam-Broome

The test build / client_test failing seems to be an infrastructural issue. I can see that the PR previous to this also has this issue.

Liam-Broome avatar Nov 19 '25 17:11 Liam-Broome

The test build / client_test failing seems to be an infrastructural issue. I can see that the PR previous to this also has this issue.

yes, MC-304369

maityyy avatar Nov 20 '25 11:11 maityyy

Wait don't merge yet

ekulxam avatar Nov 22 '25 01:11 ekulxam

@Liam-Broome are you still working on this? If not, then I'd like to implement the requested changes myself. No worries if you're busy.

ekulxam avatar Dec 06 '25 07:12 ekulxam

@ekulxam - Feel free to take over 😀

Liam-Broome avatar Dec 06 '25 08:12 Liam-Broome

@Liam-Broome I've made a pull request to your fork https://github.com/Liam-Broome/fabric/pull/1

ekulxam avatar Dec 08 '25 02:12 ekulxam