fabric icon indicating copy to clipboard operation
fabric copied to clipboard

Updating food tags to have separation of golden & non-golden foods

Open Bowswa opened this issue 1 year ago • 2 comments

Modify Standard Tags Data Generator -Structured to not break mods -Added tags for golden VS nongolden fruits & veggies -Those tags are included in the original tag as "optional".

Meant to fix #3899

Bowswa avatar Jun 30 '24 16:06 Bowswa

You are missing the lang file datagen as well. And you need to run the datagenerators. Also, these new fields are not even added to ConventionalItemTags so this would not even compile. I would encourage only making edits while having the code opened in an IDE so you can run all the needed tasks, spotless, and datagenerators

TelepathicGrunt avatar Jul 04 '24 11:07 TelepathicGrunt

Also, would the actual tag be

c:foods/golden_fruit c:foods/normal_fruit and then collect those two tags into c:foods/fruit

Or do c:foods/fruit/golden c:foods/fruit/golden and then collect those two tags into c:foods/fruit

Leaning towards c:foods/fruit/golden c:foods/fruit/regular and then collect those two tags into c:foods/fruit

TelepathicGrunt avatar Jul 04 '24 12:07 TelepathicGrunt

@Bowswa I added c:foods/golden in this PR instead. https://github.com/FabricMC/fabric/pull/3912

The reason i did not split the Fruits and Vegetable tags is because people can add other golden foods like meat and such. So rather than open that can of worms of golden tags everywhere, I added a single tag for golden foods.

To make best use of that new golden tag, please checkout net.fabricmc.fabric.api.recipe.v1.ingredient.DefaultCustomIngredients as it give you the ability to do tag intersections and differences. This allows recipes to do an intersection on Fruits and Golden to get the two golden apple foods plus other modded golden fruits. You can also do the difference of fruits and golden to get all non-golden fruits.

Now if you have any datapacks that is supposed to work in vanilla and Fabric at same time, take a look into Overlays. https://gist.github.com/lukebemish/91431e6bdabd495e692e7069d822f1ae It is a vanilla feature where you can load a vanilla-based recipe if not on fabric (you own tag of fruits you want) and when on fabric, then load the special fabric ingredient based recipe. This will become viable one https://github.com/FabricMC/fabric/pull/3872 is merged

TelepathicGrunt avatar Jul 05 '24 19:07 TelepathicGrunt

Closing this in favor of @TelepathicGrunt 's. Many thanks for the help. 👍

modmuss50 avatar Jul 06 '24 10:07 modmuss50