Water/Foliage Color Modification Not Working

[AViewFromTheTop]

Has stopped working for quite a while. Only seems to impact modded biomes.

[modmuss50]

Have you got a minimal way to reproduce this? How are you adding the modded biome?

[AViewFromTheTop]

Have you got a minimal way to reproduce this? How are you adding the modded biome?

I'm registering them through datagen. We do have a custom FrozenBiome class, but it's the same as how vanilla builds its biomes- just streamlined into separate classes.

BiomeModifications.create(WilderSharedConstants.id("modify_hot_water")).add( ModificationPhase.REPLACEMENTS, BiomeSelectors.all(), (selectionContext, modificationContext) -> { BiomeModificationContext.EffectsContext context = modificationContext.getEffects(); context.setWaterColor(0); context.setWaterFogColor(0); });

[AViewFromTheTop]

If a screenshot's easier, here it is. It only works on biomes we've added, nothing else.

[AViewFromTheTop]

Seems to only impact 1.20.5 versions.

[dayofpi]

I'm having almost the same issue in 1.20.5 release, I call this in my modinitializer but it doesn't change the grass color

        BiomeModifications.create(new Identifier(Bitty.MOD_ID, "birch_overhaul"))
                .add(ModificationPhase.REPLACEMENTS, biomeSelectionContext -> BittyConfig.birchOverhaul && biomeSelectionContext.hasTag(ConventionalBiomeTags.IS_BIRCH_FOREST), context -> {
                    context.getEffects().setGrassColor(10475854);
                });