fabric icon indicating copy to clipboard operation
fabric copied to clipboard

Resource loader: mark impl as internal, fix deprecated loader API use

Open apple502j opened this issue 1 year ago • 2 comments

This marks the rest of impl classes as internal, marks ResourceManagerHelper as non-extendable, fixes use of deprecated Loader APIs, and fixes javadocs.

Originally included changes on keyed reloaders (support for predicate/modifier) but excluded in this PR. In v1 we should make this use event phases.

apple502j avatar Oct 13 '22 12:10 apple502j

Should the internal annotation be on the entire package instead of the individual classes?

If a package is marked with this annotation, all its containing classes are considered internal.

https://javadoc.io/doc/org.jetbrains/annotations/latest/org/jetbrains/annotations/ApiStatus.Internal.html

Juuxel avatar Oct 13 '22 12:10 Juuxel

Ah, that could be better. Maybe I should use that instead.

apple502j avatar Oct 13 '22 14:10 apple502j

@apple502j Mind fixing the build? :)

Technici4n avatar Oct 18 '22 16:10 Technici4n

This can be merged to 1.19.2, seems like the 22w42a port refactors this completely making this unnecessary.

apple502j avatar Oct 20 '22 03:10 apple502j