fabric icon indicating copy to clipboard operation
fabric copied to clipboard

Fabric Data Generation: FabricSoundProvider

Open IMB11 opened this issue 1 year ago • 10 comments

sounds.json Entry Helper | SoundEventEntry

Mojang does not specifically provide codecs for the sounds.json format, since the sounds.json provider (FabricSoundsProvider) required a class to store data on entries, I have provided a few codecs that may be useful to modders because the entry helper utilizes the same structure defined by Minecraft.

More info on structure on Minecraft Wiki

FabricSoundsProvider

tbd, still in progress

IMB11 avatar Sep 11 '22 20:09 IMB11

I'd avoid the breaking changes, the restructuring doesn't seem necessary here.

Juuxel avatar Sep 11 '22 20:09 Juuxel

Its getting very large though - are package restructuring considered breaking changes? Functionality stays the same?

IMB11 avatar Sep 11 '22 20:09 IMB11

Yeah, they're breaking changes - running mods built against older versions would crash and compiling old code against the new version would fail.

edit: Ah yes, github is breaking again

Juuxel avatar Sep 11 '22 20:09 Juuxel

You've just gotta update the imports, unless that causes problems - which it shouldn't?

IMB11 avatar Sep 11 '22 20:09 IMB11

Yeah, they're breaking changes - running mods built against older versions would crash and compiling old code against the new version would fail.

Juuxel avatar Sep 11 '22 20:09 Juuxel

Ah I see - okay, i'll sort it out then

IMB11 avatar Sep 11 '22 20:09 IMB11

Reverted

IMB11 avatar Sep 11 '22 20:09 IMB11

You can probably use the new package style for new stuff.

apple502j avatar Sep 12 '22 03:09 apple502j

Closing, will re-PR for hacktoberfest because why not? :D

IMB11 avatar Sep 30 '22 08:09 IMB11

I don’t think that’s a good idea. You loose all of the comment history. Makes it harder to find the discussion in the future.

modmuss50 avatar Sep 30 '22 08:09 modmuss50