fabric icon indicating copy to clipboard operation
fabric copied to clipboard

add fix to AFTER_PLAYER_CHANGE_WORLD

Open CalebBassham opened this issue 1 year ago • 4 comments

Adds a workaround to still call the AFTER_PLAYER_CHANGE_WORLD event when a player is moving from the end to the overworld.

CalebBassham avatar Aug 09 '22 01:08 CalebBassham

Not sure if this is the best idea, two different things should not trigger the same event.

apple502j avatar Aug 09 '22 04:08 apple502j

I mean, as long as the event is only called once when a player changed worlds, I would say that this is fine. I would not expect the average person using the api to expect that AFTER_PLAYER_CHANGE_WORLD does not apply to changing worlds from the end to the overworld.

CalebBassham avatar Aug 09 '22 05:08 CalebBassham

If the player is killed and resurrected, wouldn't some sort of player resurrect event make more sense for this?

Technici4n avatar Aug 10 '22 11:08 Technici4n

They aren't really killed. They are just removed from all worlds while they are on the credits screen.

CalebBassham avatar Aug 10 '22 18:08 CalebBassham