fabric icon indicating copy to clipboard operation
fabric copied to clipboard

[Feature Request] Separate pack versions in a pack.mcmeta file

Open Jab125 opened this issue 2 years ago • 6 comments

In 1.18.2 data packs' pack version was bumped from 8 to 9, making the data and resource version different for the first time. There is only one pack_format in a pack.mcmeta

{
  "pack": {
    "pack_format": 8,
    "description": "Fabric Resource Loader Test Builtin Pack."
  }
}

But we can create a pack with data and assets, so shouldn't we be able to separate data and assets in the pack_version? Example:

{
  "pack": {
    "fabric:data_format": 9,
    "fabric:assets_format" 8,
    "description": "Fabric Resource Loader Test Builtin Pack."
  }
}

This issue basically mirrors https://github.com/MinecraftForge/MinecraftForge/issues/8563

Jab125 avatar Apr 21 '22 02:04 Jab125

Is there any reason you don't use two different built-in packs?

Forge requires each mod to explicitly provide a pack.mcmeta file, however Fabric doesn't, hence it doesn't have this problem for mod resource packs. (Which is what the linked Forge issue is about).

Technici4n avatar Apr 21 '22 17:04 Technici4n

But, fabric packs support adding assets and data.

The easiest way to fix it probably is to remove the ability to make a pack supporting both.

Jab125 avatar Apr 22 '22 10:04 Jab125

Mojang has already removed pack.mcmeta in both client and server jars. We should probably find a way for mod resource and data packs to define their custom metadata; for example, we can still use json, but the path to the data/resource metadata will probably be defined in fabric.mod.json's custom attributes, or we can define it in code.

liach avatar Apr 25 '22 00:04 liach

I'm still not sure why this matters since we don't have a pack.mcmeta file on Fabric for packs? Or is there one for builtin packs added via resource loader?

Technici4n avatar Jun 08 '22 11:06 Technici4n

I'm still not sure why this matters since we don't have a pack.mcmeta file on Fabric for packs? Or is there one for builtin packs added via resource loader?

ones added by fabric resource loader

Jab125 avatar Jun 08 '22 11:06 Jab125

Ok yeah, seems sensible.

Technici4n avatar Jun 08 '22 11:06 Technici4n

I don't think this is really useful compared to just using separate builtin packs. After all, data packs and resource packs are handled differently by MC.

Technici4n avatar Aug 30 '22 18:08 Technici4n