fabric icon indicating copy to clipboard operation
fabric copied to clipboard

Add fog customization to rendering-fluids module.

Open devpelux opened this issue 2 years ago • 1 comments

Scope of the PR

Update the FluidRenderHandler by including a FluidFogHandler to customize the fog rendered when the player camera is inside the fluid.

devpelux avatar Mar 27 '22 20:03 devpelux

July 2022 Updates

I tried to add the new 1.19 system to handle fog effects (darkness / blindness), but the result was too much specified and hardcoded, overriding the fog parameters or making impossible to add future effects that will increase the fog radius... the result is that is better to leave this PR unhaltered and more generic as possible, and leave the dev the job to specify what to do with fog.

To generalize it better, i've merged the 3 parameters (the 2 radiuses and the shape) into one object, with one method to retrieve them. I've also added the tickDelta and skyDarkness parameters to FluidFogHandler methods. So there are two methods that are basically an extension of render and applyFog methods in BackgroundRenderer.

Now the target is 1.19.1.

I think this is complete, no further changes will be made, except those requested by eventually reviews.

devpelux avatar Jul 31 '22 15:07 devpelux