fabric icon indicating copy to clipboard operation
fabric copied to clipboard

Item stack clicking interaction events

Open BoogieMonster1O1 opened this issue 5 years ago • 4 comments

This adds two interaction events that fire before ItemStack#onClicked and ItemStack#onStackClicked. Both are cancellable.

here's the testmod (a miniature fluid api 😄) - https://i.imgur.com/2APkSj3.mp4

BoogieMonster1O1 avatar Nov 28 '20 15:11 BoogieMonster1O1

Seems like you have some unused imports which makes the checks fail

oliviathevampire avatar Nov 28 '20 17:11 oliviathevampire

The API looks fine to me, my only suggestion would be to maybe simplify the test mod? It seems a bit complicated and is nearly half of the PR. It's also not entirely clear to me from your video how it is supposed to be working. Perhaps some more obvious and simplified tests would be better, and more helpful to future maintainers of this code.

Prospector avatar Nov 30 '20 02:11 Prospector

Any updates?

maityyy avatar Dec 17 '21 04:12 maityyy

Any updates?

another abandoned fabric pr in the bag

kanpov avatar Jan 03 '22 11:01 kanpov