fabric-loader icon indicating copy to clipboard operation
fabric-loader copied to clipboard

McVersionLookup doesn't allow `in-` versions

Open maruohon opened this issue 1 year ago • 0 comments

The McVersionLookup is missing the option for version numbers in the format in-20100223 due to one missing ? in the regex. inf-20100223 would be valid, as would Indev 20100223 and Infdev 20100223, but currently not in-20100223. (ofc there is no Infdev version with this date, it's just an example here).

https://github.com/FabricMC/fabric-loader/blob/9e6fc1b2ae62d760e55405e3e48c835bb8849699/minecraft/src/main/java/net/fabricmc/loader/impl/game/minecraft/McVersionLookup.java#L69

- "(?:inf-|Inf?dev )(?:0\\.31 )?(\\d+(-\\d+)?)"
+ "(?:inf?-|Inf?dev )(?:0\\.31 )?(\\d+(-\\d+)?)"

maruohon avatar Sep 05 '24 20:09 maruohon