fabric-loader icon indicating copy to clipboard operation
fabric-loader copied to clipboard
verified publisher icon FabricMC

Running PackageAccessFixer before Mixin causes warning messages

Open skyrising opened this issue 5 years ago • 2 comments

When a Mixin using an anonymous or otherwise package-private target (for example @Mixin(targets = "net.minecraft.util.Language$1")) is loaded in a development environment Mixin outputs a warning saying @Mixin target net.minecraft.util.Language$1 is public in ... and should be specified in value.

Running PackageAccessFixer before Mixin makes these classes public, which makes Mixin believe that they could have been specified in value.

skyrising avatar Oct 03 '20 12:10 skyrising

In dev there is no real way to prevent this. All I can say is that this is probably intended.

i509VCB avatar Oct 15 '20 06:10 i509VCB

Based on messages sent by modmuss50 in the discord, this is a bug that is intended to be fixed at some point, as such this issue report shouldn't be marked as wontfix.

[3:21 PM] modmuss50: We need to fix that [3:34 PM] modmuss50: These warnings are technically a loader bug

coderbot16 avatar Apr 08 '21 02:04 coderbot16