fabric-loader icon indicating copy to clipboard operation
fabric-loader copied to clipboard

Provide artifact path, url, hash and size in versions.json

Open jordanamr opened this issue 4 years ago • 7 comments

Just like in Forge : image

This would make custom launchers maintaining easier :)

jordanamr avatar Jul 20 '20 09:07 jordanamr

I dont think that format is correct above.

we could do it for most libs, however I wouldnt want to do it for intermediary as we have needed to update it during a version cycle (think when mojang re-released 1.16)

The launcher does check the sha1 of the files when launching from the .sha1 file on maven.

modmuss50 avatar Jul 20 '20 10:07 modmuss50

I dont think that format is correct above.

we could do it for most libs, however I wouldnt want to do it for intermediary as we have needed to update it during a version cycle (think when mojang re-released 1.16)

The launcher does check the sha1 of the files when launching from the .sha1 file on maven.

I took that format from the 1.16.1-forge-32.0.69.json profile file so I think it's correct. Can we get that data from the Fabric Meta HTTP API maybe instead? This is just to make sure we don't query the maven repo for every lib just for integrity checks and for ease of maintaining (getting a json with all the data and then parsing it, just like parsing the forge profile)

jordanamr avatar Jul 20 '20 10:07 jordanamr

The format isnt correct for us anyway, I think we could add this on the meta side of things as it would have a low change of breaking pre existing launchers

https://meta.fabricmc.net/v2/versions/loader/1.16.1/0.8.9+build.203/profile/json

modmuss50 avatar Jul 20 '20 10:07 modmuss50

This is currently the endpoint I am using to get the json profile, adding the extra data in there would be fabulous for launcher maintainers!

jordanamr avatar Jul 20 '20 10:07 jordanamr

I think it would be good and that's what I'm looking for

ydainna avatar Jul 26 '20 10:07 ydainna

Is there any way I can get some guidelines on how to contribute to that meta server so I could PR?

jordanamr avatar Aug 28 '20 16:08 jordanamr

The code is here: https://github.com/FabricMC/fabric-meta

sfPlayer1 avatar Aug 28 '20 16:08 sfPlayer1