fabric-loader icon indicating copy to clipboard operation
fabric-loader copied to clipboard

Handle multiple FabricLoaderLauncherSessionListener instances.

Open modmuss50 opened this issue 1 year ago • 2 comments

It seems that the VSCode test runner will create multiple FabricLoaderLauncherSessionListener instances. We can only ever have one Knot instance so store it statically.

TODO test:

  • [x] Gradle
  • [x] Gradle via Intelij
  • [x] Intelij (without Gradle)
  • [ ] VSCode
  • [ ] Eclipse (didnt work last I tried, but it might now)

modmuss50 avatar Nov 30 '24 15:11 modmuss50

Visual Studio Code now works for running tests with these changes applied. This pull request will close #1000.

haykam821 avatar Dec 01 '24 16:12 haykam821

How can we help getting this merged? Running mutation tests using PITest cause the same issue and this will probably fix it as well (I'm not sure how to test these changes locally)

CodexNotFound avatar Apr 29 '25 12:04 CodexNotFound