fabric-language-kotlin icon indicating copy to clipboard operation
fabric-language-kotlin copied to clipboard

Suggestion: Include kotlin-metadata-jvm

Open serenyadev opened this issue 6 months ago • 5 comments

As the title suggests, include kotlin-metadata-jvm module

serenyadev avatar Apr 16 '25 02:04 serenyadev

Hey, I'm not against this, my only concern is the metadata jar is 1MB for something that I'm not sure many mods will use.

What's your use case?

modmuss50 avatar Apr 16 '25 07:04 modmuss50

Need to read kotlin metadata in some asm thing (so cant use reflection there) bit of a niche but i could see more use cases for it

serenyadev avatar Apr 16 '25 15:04 serenyadev

Is there anything stopping you from JIJ'ing it into your own mod? This might be best. An extra MB is quite a bit for a really niche use case.

modmuss50 avatar Apr 16 '25 17:04 modmuss50

No thats fine. Was honestly not aware of the file size, my thoughts was just that itd be easier to keep the latest version if its in flk.

serenyadev avatar Apr 16 '25 19:04 serenyadev

so you can close if you wanna

serenyadev avatar Apr 16 '25 19:04 serenyadev