fabric-example-mod icon indicating copy to clipboard operation
fabric-example-mod copied to clipboard

Fix VSCode support in .gitignore

Open NatoBoram opened this issue 6 years ago • 3 comments

The current .gitignore for VSCode is this :

# vscode

.settings/
.vscode/
bin/
.classpath
.project

While in reality, it should be that :

.vscode/*
!.vscode/settings.json
!.vscode/tasks.json
!.vscode/launch.json
!.vscode/extensions.json

You can view proper templates for .gitignore in github.com/github/gitignore.

A useful tool to generate .gitignore can be found at gitignore.io. Personally, I love this tool. I'm not a fan of having to look for each individual .gitignore for every project I create, I'm way too lazy for that.

The .classpath, .project, .settings and .factorypath are added by Language Support for Java(TM) by Red Hat inside .vscode/settings.json. Well, they should probably be also inside .gitignore, but I think that they should be in a separate "block" from VSCode.

NatoBoram avatar Aug 08 '19 14:08 NatoBoram

Im not sure this is fully correct. The launch jsons change based on the system they are being ran as. Possibly just ingoring the launch.json would be a solution.

modmuss50 avatar Feb 28 '20 12:02 modmuss50

If the project maintainer wants to share a specific launch config with the users of this project, then it's there.

Here's more insight from someone working directly on VSCode : https://stackoverflow.com/a/32979933/5083247

NatoBoram avatar Mar 03 '20 00:03 NatoBoram

Fabrics launch files will not translate across systems, if a project specific run arg needs to be added it should be done through gradle. If the ability to do that doesn’t exist open a loom issue

modmuss50 avatar Mar 03 '20 00:03 modmuss50

This is still correct, you should have a fresh set of launch configs for each machine.

modmuss50 avatar Nov 22 '22 15:11 modmuss50