fabric-docs icon indicating copy to clipboard operation
fabric-docs copied to clipboard

SoundInstances page

Open JR1811 opened this issue 1 year ago • 2 comments

From Issue #70

Content

This page is split into several parts.

  1. again, preparing sound files for SoundInstances
  2. using basic SoundInstances
  3. Advanced SoundInstance usage example

The page first explains how to create and use simple SoundInstances and then shows an example of how to make a sound system, which can modulate e.g. its volume and pitch based on the current sound phase and connected BlockEntity values.

Problems & Questions

The current page has not been cleaned up and spellchecked yet. The main reason I'm PRing this now is to ask for opinions. I was about to delete the 3rd section (starting from the Advanced SoundInstances header) because of the scope of this topic. But it shows how abstract systems can be created. I'm pretty sure this "huge" in-depth example does not belong in the Fabric Docs, but I wanted to hear other opinions before I scrap all of that again.

The Choices before I move into the clean-up phase:

  • keep the current example in (with clean-up etc. afterwards)
  • massively shrink down / rework the example by losing most of the abstractions and inheritance
  • take the whole example out, only the basic SoundInstance usage is needed

This page uses but does not cover BlockEntities and custom S2C networking. Those should be handled on separate pages.

JR1811 avatar Aug 27 '24 12:08 JR1811

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
Latest commit 1ded0095050694f44f6efea3d68c415bf18cbfe0
Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/67706beac3e8780008a54e04
Deploy Preview https://deploy-preview-174--nimble-elf-d9d491.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 27 '24 12:08 netlify[bot]

I this is is well written and should be added

Tewxx avatar Sep 16 '24 22:09 Tewxx

Just wondering. Has anyone checked this yet? If it's in a usable state, ill clean it up / continue working on it.

Otherwise, we can just get rid of this page.

JR1811 avatar Dec 19 '24 02:12 JR1811

This is incredibly well made.

IMB11 avatar Dec 27 '24 12:12 IMB11

Please can you fix the spotless issues and markdownlint issues present, and then LGTM.

IMB11 avatar Dec 27 '24 12:12 IMB11

LGTM @IMB11

its-miroma avatar Dec 28 '24 21:12 its-miroma