fabric-docs
fabric-docs copied to clipboard
Partial fix for #95
There are currently two problems with CONTRIBUTING:
- The links used are all absolute, so
CONTRIBUTINGwill always be in English - You're trying to redirect
/CONTRIBUTINGto/contributing, for aesthetic reasons
Possible solutions for the first problem include:
- Using relative links in files (DONE)
- The top bar can't use a relative link, because that only works on the homepage (see comment in source code)
Possible solutions for the second problem include:
- Simply renaming
CONTRIBUTING.mdtocontributing.md, easiest solution - Accepting that the aesthetic redirect will only work for English, because of how Vitepress works (only one
rewriteis applied for each page, I think; I couldn't figure out why)
Deploy Preview for nimble-elf-d9d491 ready!
| Name | Link |
|---|---|
| Latest commit | 95865ab87ed66e63b412da118c6ade8181e925f4 |
| Latest deploy log | https://app.netlify.com/sites/nimble-elf-d9d491/deploys/6669f1bd83cbc600086b0db9 |
| Deploy Preview | https://deploy-preview-100--nimble-elf-d9d491.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
The preview doesn't currently work for other languages because their files still use absolute links.
Update: it fixes the top bar, but not the pages
I asked for help over at Vitepress, and they told me that we were doing it wrong.
I have fixed it now, but there is some refactoring I would like to do. I do not have time for that right now, I'll see when I can do it.
I also don't know what I should do with the CONTRIBUTING.md files in translated/; I moved them to the lowercase version in a separate commit, if that's correct, otherwise I'll drop it.
Some people on Crowdin have started using absolute language links to fix the problem on their end. Again, should I modify their files here on GitHub? Can I touch translated/?
https://github.com/FabricMC/fabric-docs/blob/39cad1fa0f7d1f64701f0595d3d4f71ea783f494/translated/ru_ru/index.md?plain=1#L26
(PS: I do not speak Russian)
Some people on Crowdin have started using absolute language links to fix the problem on their end. Again, should I modify their files here on GitHub? Can I touch translated/?
We really need to find a way to convey the contributing guidelines to users on Crowdin, as there's no way to do this other than make the contributor process invite-only.
I dont think this implementation will work with versioning, please test it out if you can.
Does this mean that we need to stop using absolute links now?
Does this mean that we need to stop using absolute links now?
You should have always been using relative links in translations.
I dont think this implementation will work with versioning, please test it out if you can.
It didn't. ~~https://github.com/IMB11/vitepress-versioning-plugin/pull/4~~ ~~Update: waiting for release~~ Update: Released
Will publish a version for you now.
0.11.0 is out, update when you can :+1:
Actually i'll do it now when adding support for nav translations
I think we should merge this without the localisation of the version switcher for now, it can come at a later date.
LGTM @modmuss50