Enigma icon indicating copy to clipboard operation
Enigma copied to clipboard

Tag based versioning/builds?

Open 2xsaiko opened this issue 4 years ago • 3 comments

Could we have Enigma build only when a new tag gets pushed and then take the version number from that tag? I have something similar set up for my mods and other stuff, here.

This would mean you could only trigger a build and bump the version at the same time, by doing something like git tag -a 0.xx, which prevents accidentally merging a PR without bumping the version :P (And having to edit build.gradle every time.)

2xsaiko avatar Jun 08 '20 20:06 2xsaiko

Adding to this, I often use the output of git describe as it includes the tag, how many commits since that tag and a sha ref.

This means that merging a pr without adding a tag will still result in a new version number (even without Jenkins' build number being tacked on)

thiakil avatar Jul 19 '20 02:07 thiakil

Can this be closed?

YanisBft avatar May 24 '21 13:05 YanisBft

I believe I was talking to @modmuss50 about this when he set up actions, I believe he said that I should try the current actions workflow and see how it is first. I'd say it's okay now as it is but I'd still think tags are a better way to go.

2xsaiko avatar May 24 '21 16:05 2xsaiko